OAuth: Apache OLTU to Nimbusds #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for remote projects and galaxy
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/ca/corefacility/bioinformatics/irida/exceptions/IridaOAuthProblemException.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/exceptions/IridaOAuthProblemException.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/exceptions/IridaOAuthProblemException.java
Outdated
Show resolved
Hide resolved
apetkau
requested changes
Jan 26, 2023
.../ca/corefacility/bioinformatics/irida/ria/web/oauth/GalaxyRedirectionEndpointController.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/RemoteAPITokenServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/RemoteAPITokenServiceImpl.java
Outdated
Show resolved
Hide resolved
|
Oh, also please add an entry to |
…ch blocks and more explicit logging.
This does touch the code used to sync between old and new IRIDA instances, but it does not break compatibility with older instances. The reason being that we are still performing the same OAuth flow, we are just using a different library that is still being supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Replaced end of life Apache OLTU library with Nimbusds, which is a currently maintained library. This code change affects OAuth flow for IRIDA to IRIDA syncing and Galaxy import tool.
To test this I would follow the process for setting up a remote project and also test out the irida-galaxy-importer tool, against a server running this code.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted: